On 2/2/2021 2:19 AM, Ruifeng Wang wrote:
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Tuesday, February 2, 2021 6:42 AM
To: Jan Viktorin <[email protected]>; Ruifeng Wang
<[email protected]>; [email protected]; Bruce Richardson
<[email protected]>; Juraj Linkeš <[email protected]>;
Honnappa Nagarahalli <[email protected]>; Vimal Chungath
<[email protected]>
Cc: Ferruh Yigit <[email protected]>; [email protected];
[email protected]; [email protected]; Thierry Herbelot
<[email protected]>
Subject: [PATCH] config/arm: fix typo in meson config
s/implementor/implementer
Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
Fixes: c51401832147 ("config/arm: add Graviton2")
'implementor' -> 'implementer' change was made in 7870ae8994c6.
It seems 7870ae8994c6 missed Graviton2 config file which was added earlier.
Right, I missed the rename patch, so it should be:
Fixes: 7870ae8994c6 ("config/arm: rename variables")
And that rename patch does 'implementor_pn' -> 'part_number', so I will update
this patch to do the same.
With the fix tag update,
Reviewed-by: Ruifeng Wang <[email protected]>
Cc: [email protected]
Reported-by: Thierry Herbelot <[email protected]>
Signed-off-by: Ferruh Yigit <[email protected]>
---
Cc: Juraj Linkeš <[email protected]>
Cc: Ruifeng Wang <[email protected]>
Cc: [email protected]
---
config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++--
config/arm/arm64_graviton2_linux_gcc | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804
b/config/arm/arm64_armv8_linux_clang_ubuntu1804
index aa5ee0132065..ae3fb30c5da8 100644
--- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
+++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
@@ -14,7 +14,7 @@ cpu = 'armv8-a'
endian = 'little'
[properties]
-implementor_id = 'generic'
-implementor_pn = 'default'
+implementer_id = 'generic'
+implementer_pn = 'default'
c_args = ['-target', 'aarch64-linux-gnu', '--sysroot',
'/usr/aarch64-linux-gnu']
c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-
toolchain=/usr'] diff --git a/config/arm/arm64_graviton2_linux_gcc
b/config/arm/arm64_graviton2_linux_gcc
index cfe2397975fc..123f14eed29e 100644
--- a/config/arm/arm64_graviton2_linux_gcc
+++ b/config/arm/arm64_graviton2_linux_gcc
@@ -13,8 +13,8 @@ cpu = 'armv8-a'
endian = 'little'
[properties]
-implementor_id = '0x41'
-implementor_pn = '0xd0c'
+implementer_id = '0x41'
+implementer_pn = '0xd0c'
max_lcores = 64
max_numa_nodes = 1
numa = false
--
2.29.2
