> -----Original Message-----
> From: Wu, Wenjun1 <[email protected]>
> Sent: Tuesday, March 2, 2021 13:31
> To: [email protected]; Yang, Qiming <[email protected]>; Zhang, Qi Z
> <[email protected]>
> Cc: Wu, Wenjun1 <[email protected]>; [email protected]
> Subject: [PATCH v1] net/ice: fix wrong RSS hash update
>
> This patch removes redundant judgment statements to disable RSS when RSS
> hash function configured is not supported.
>
> Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user
> config")
> Cc: [email protected]
>
> Signed-off-by: Wenjun Wu <[email protected]>
> ---
> drivers/net/ice/ice_ethdev.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> f43b2e0b2..a84b3d3c0 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -4461,9 +4461,6 @@ ice_rss_hash_update(struct rte_eth_dev *dev,
> if (status)
> return status;
>
> - if (rss_conf->rss_hf == 0)
> - return 0;
> -
Why need to delete this code? It's a code clean to avoid to do more judgement
in the next funxtion.
> /* RSS hash configuration */
> ice_rss_hash_set(pf, rss_conf->rss_hf);
>
> --
> 2.25.1
