On 3/8/2021 10:29 PM, Ed Czeck wrote:
- Rename extension functions with rte_pmd_ark prefix
- Move extension prototype to rte_pmd_ark.h
- Update documentation for extension

Hi Ed,

I think better to have the documentation with the previous patch, where it has the hooks. It has a benefit to have the documentation and the code in same commit, when you want to investigate some code it is easy the find the commit that has been introduced and documentation being in the same commit gives the full intentions to investigate, if documentation is in different commit it is easy the miss the documentation part. But I can see documentation is using renamed, and latest, APIs that may be the reason to have the documentation in this commit.

Sorry it will require some playing with git but can you do the renaming first, and in second patch you can add the new hooks with documentation in same patch? This way the API names will be correct in the documentation again when you add it.

Thanks,
ferruh


Signed-off-by: Ed Czeck <ed.cz...@atomicrules.com>
---
v3:
- split function rename from previous commit

<...>

Reply via email to