> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 29, 2015 9:06 AM > To: Zhang, Helin > Cc: Gonzalez Monroy, Sergio; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: fix build > > 2015-07-29 15:09, Zhang, Helin: > > From: Gonzalez Monroy, Sergio > > > Fixes: 4d4ebca4 ("pci: merge probing and closing functions for linux > > > and bsd") > > > > > > The function rte_eal_pci_probe_one_driver, which calls > > > pci_config_space_set, was moved to eal_common_pci.c, but > > > pci_config_space_set was left in eal_pci.c with static specifier. > > > > Yes, that's the root cause. > > I am just have a thought that we may need to move all of those three > > functions together into eal_common_pci.c, which can avoid exporting that > function. > > No it is specific to Linux (implemented in igb_uio only). > But it may be moved to eal_common if you remove the igb_uio patch and use > the new functions to access to PCI config with UIO or VFIO: > http://dpdk.org/browse/dpdk/commit/?id=632b2d1deeed Yes, I agree. It should be moved into i40e PMD only according to the user configurations.
Regards, Helin > > This build fix will be applied for 2.1. > It is expected the above rework will be done for 2.2. > Thanks
