On 3/12/21 11:22 AM, Thomas Monjalon wrote: > 12/03/2021 02:44, Wang, Haiyue: >> From: Thomas Monjalon <tho...@monjalon.net> >>> -typedef int (*eth_filter_ctrl_t)(struct rte_eth_dev *dev, >>> - enum rte_filter_type filter_type, >>> - enum rte_filter_op filter_op, >>> - void *arg); >>> -/**< @internal Take operations to assigned filter type on an Ethernet >>> device */ >>> +struct rte_flow_ops; >>> +typedef int (*eth_flow_ops_get_t)(struct rte_eth_dev *dev, >>> + const struct rte_flow_ops **ops); >>> +/**< @internal Get flow operations */ >>> >> >> How about to change the return type to "const struct rte_flow_ops *" >> directly ? >> >> typedef const struct rte_flow_ops * (*eth_flow_ops_get_t)(struct rte_eth_dev >> *dev); > > Not sure. > Returning an int may allow different error codes. > Any opinions? >
I would keep int return value. There is no point to optimize it (make it simpler). It is called in just one place where int return value may be used/forwarded (see my review notes).
