Hi Thomas, > -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Tuesday, March 9, 2021 9:39 PM > To: Jiawei(Jonny) Wang <jiaw...@nvidia.com> > Cc: Slava Ovsiienko <viachesl...@nvidia.com>; Matan Azrad > <ma...@nvidia.com>; Ori Kam <or...@nvidia.com>; dev@dpdk.org; Raslan > Darawsheh <rasl...@nvidia.com> > Subject: Re: [PATCH] doc: update sample actions support in mlx5 guide > > 09/03/2021 14:09, Jiawei Wang: > > + - Supports ``MARK``, ``COUNT``, ``QUEUE``, ``RSS`` as sample actions for > NIC Rx sampling/mirroring flow. > > "sample actions for NIC Rx sampling" is redundant. > I suggest "Supports [...] actions for NIC Rx flow sampling/mirroring." >
These actions are support in the sample action list, user also can add modify, decap , encap in the NIC RX flow; How about this: "For NIC RX flow with sample action, Supports [...] actions in the sample action list" ? > > + - Supports ``RAW ENCAP``, ``Port ID`` as sample actions for E-Switch > mirroring (sample ratio = 1) flow. > > I suggest "Supports [...] actions for E-Switch flow mirroring." > > If lines are long, do not hesitate to start a new line after a punctuation. > Ok, I will split into two lines. Thanks.
