> -----Original Message-----
> From: Richardson, Bruce <[email protected]>
> Sent: Tuesday, March 16, 2021 10:13 PM
> To: Thomas Monjalon <[email protected]>
> Cc: Zhang, Qi Z <[email protected]>; Andrew Rybchenko
> <[email protected]>; Yigit, Ferruh <[email protected]>;
> [email protected]; Wang, Xiao W <[email protected]>; Wu, Jingjing
> <[email protected]>; Xing, Beilei <[email protected]>; Guo, Jia
> <[email protected]>; Yang, Qiming <[email protected]>; Wang, Haiyue
> <[email protected]>
> Subject: Re: [PATCH v2 1/8] ether: refine debug compile option
>
> On Tue, Mar 16, 2021 at 02:39:05PM +0100, Thomas Monjalon wrote:
> > 16/03/2021 14:05, Ferruh Yigit:
> > > On 3/12/2021 12:12 PM, Qi Zhang wrote:
> > > > PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as compile option
> to
> > > > wrap data path debug code. As .config has been removed since the
> > > > meson build, It is not friendly for new DPDK users to notice those debug
> options.
> > > >
> > > > The patch introduces below compile options for specific Rx/Tx data
> > > > path debug, so PMD can choose to reuse them to avoid maintain their
> own.
> > > >
> > > > - RTE_LIBRTE_ETHDEV_DEBUG_RX
> > > > - RTE_LIBRTE_ETHDEV_DEBUG_TX
> > > >
> > > > Also, all the compile options are documented on the overview page,
> > > > so users can easily find them.
> >
> > English question: is "compile option" correct, or should it be
> > "compilation option"?
> > Cc Bruce to have a native in the discussion :)
> >
>
> "compilation options" is better.
> However, throughout this patch, I wonder if "build" might be a better verb to
> use than "compile".
OK, I will use "build" in v3, thanks!
