On 3/9/2021 9:48 AM, Thomas Monjalon wrote:
The macro DEBUG was doing nothing if not compiled with RTE_LIBRTE_MLX4_DEBUG.As it is not used in the data path, it can be always enabled at compilation time. Then it can be enabled at runtime with: --log-level pmd.net.mlx4:debug Signed-off-by: Thomas Monjalon <[email protected]>
+1 to change, but why 'RTE_LIBRTE_MLX4_DEBUG' exists at first place? It seems is is used both for data and control path, can you extend the patch for: 1- Remove #ifdef from control path 2- Replace with 'RTE_ETHDEV_DEBUG_RX' & 'RTE_ETHDEV_DEBUG_TX' for data path, please see: https://patches.dpdk.org/project/dpdk/list/?series=15738 3- Remove 'RTE_LIBRTE_MLX4_DEBUG' completely, if not removed document it in the driver documentation as supported config file
