On 23/03/2021 09:57, Dmitry Kozlyuk wrote:
> 2021-03-23 09:34 (UTC+0000), Kinsella, Ray:
>> On 23/03/2021 09:33, Kinsella, Ray wrote:
>>>
>>>
>>> On 22/03/2021 23:32, Dmitry Kozlyuk wrote:
>>>> 2021-03-16 20:45 (UTC+0800), Xueming Li:
>>>> [...]
>> [SNIP]
>>>>> rte_mem_page_size;
>>>>
>>>> New function is private to EAL, so it doesn't need exporting.
>>>>
>>>
>>> Right - it is annotated as INTERNAL.
>>>
>>
>> Sorry, let me be clearer - it is being correctly annotated unless I have
>> missed something.
>
> This function is purely internal to librte_eal. It doesn't need to be added
> to .map or .def. It also doesn't need __rte_internal, like other functions in
> eal_private.h don't need it either.
>
ok - I get you now - agreed.
