On 3/24/2021 6:32 PM, Yong Wang wrote:
-----Original Message----- From: Dmitry Kozlyuk <[email protected]> Date: Wednesday, March 24, 2021 at 10:50 AM To: Yong Wang <[email protected]> Cc: Ferruh Yigit <[email protected]>, "[email protected]" <[email protected]>, Narcisa Ana Maria Vasile <[email protected]>, Dmitry Malloy <[email protected]>, Pallavi Kadam <[email protected]> Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows 2021-03-23 17:13 (UTC+0000), Yong Wang: > -----Original Message----- > From: Ferruh Yigit <[email protected]> > Date: Tuesday, March 23, 2021 at 9:11 AM > To: Dmitry Kozlyuk <[email protected]>, "[email protected]" <[email protected]>, Yong Wang <[email protected]> > Cc: Narcisa Ana Maria Vasile <[email protected]>, Dmitry Malloy <[email protected]>, Pallavi Kadam <[email protected]> > Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows > > On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote: > > Remove OS restriction and update release notes. > > > > Signed-off-by: Dmitry Kozlyuk <[email protected]> > > Build looks good, but I wonder if anyone tested the driver on Windows. > > Yong, > > Do you have any plan to test the driver on Windows, should we wait your ack? > > Ferruh, > > Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change? For the record, I tested the following setup with Windows Server 2019 in QEMU (-device vmxnet3) before submitting the patch: [ping ] [ ] [ ping] [OS ] [ dpdk-skeleton ] [ OS] [virtio---]--sockets--[---vmxnet3 vmxnet3---]--sockets--[---virtio] [Debian VM] [ Windows VM ] [Debian VM] Debian VMs successfully ping'd each other with Windows forwarding. Thanks Dmitri for the testing results. It will be good if you can try some basic tcp/udp traffic as well. Acked-by: Yong Wang <[email protected]>
Applied to dpdk-next-net/main, thanks. Added the above test detail to commit log for record.
