> -----Original Message----- > From: wangyunjian <[email protected]> > Sent: Friday, March 26, 2021 12:37 > To: [email protected] > Cc: Matan Azrad <[email protected]>; Shahaf Shuler > <[email protected]>; Slava Ovsiienko <[email protected]>; > [email protected]; [email protected]; Yunjian Wang > <[email protected]> > Subject: [dpdk-dev] [PATCH] net/mlx5: fix using flow tunnel before null > check > > From: Yunjian Wang <[email protected]> > > Coverity flags that 'ctx->tunnel' variable is used before it's checked for > NULL. > This patch fixes this issue. > > Coverity issue: 366201 > Fixes: 868d2e342cf3 ("net/mlx5: fix tunnel offload hub multi-thread > protection") > > Signed-off-by: Yunjian Wang <[email protected]> Acked-by: Viacheslav Ovsiienko <[email protected]>
Thank you for the patch. I suppose, this one should be the part of 20.11LTS either. Could you, please, add "cc: [email protected]" and send v2? With best regards, Slava > --- > drivers/net/mlx5/mlx5_flow.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index d46fc333d1..bb8d09cdef 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -7899,10 +7899,11 @@ static void get_tunnel_miss(struct rte_eth_dev > *dev, void *x) > > rte_spinlock_unlock(&thub->sl); > ctx->tunnel = mlx5_flow_tunnel_allocate(dev, ctx->app_tunnel); > - ctx->tunnel->refctn = 1; > rte_spinlock_lock(&thub->sl); > - if (ctx->tunnel) > + if (ctx->tunnel) { > + ctx->tunnel->refctn = 1; > LIST_INSERT_HEAD(&thub->tunnels, ctx->tunnel, chain); > + } > } > > > -- > 2.23.0
