> -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Monday, March 29, 2021 10:51 AM > To: McDaniel, Timothy <[email protected]> > Cc: dpdk-dev <[email protected]>; Jerin Jacob <[email protected]>; Van Haaren, > Harry <[email protected]>; Ray Kinsella <[email protected]>; Neil > Horman <[email protected]>; Rao, Nikhil <[email protected]>; > Carrillo, Erik G <[email protected]>; Gujjar, Abhinandan S > <[email protected]>; Pavan Nikhilesh > <[email protected]>; Hemant Agrawal <[email protected]>; > mattias.ronnblom <[email protected]>; Mccarthy, Peter > <[email protected]> > Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe > > On Mon, Mar 29, 2021 at 8:30 PM McDaniel, Timothy > <[email protected]> wrote: > > > > > > > > > -----Original Message----- > > > From: Jerin Jacob <[email protected]> > > > Sent: Friday, March 26, 2021 9:33 AM > > > To: McDaniel, Timothy <[email protected]> > > > Cc: dpdk-dev <[email protected]>; Jerin Jacob <[email protected]>; Van > Haaren, > > > Harry <[email protected]>; Ray Kinsella <[email protected]>; Neil > > > Horman <[email protected]>; Rao, Nikhil <[email protected]>; > > > Carrillo, Erik G <[email protected]>; Gujjar, Abhinandan S > > > <[email protected]>; Pavan Nikhilesh > > > <[email protected]>; Hemant Agrawal > <[email protected]>; > > > mattias.ronnblom <[email protected]>; Mccarthy, Peter > > > <[email protected]> > > > Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe > > > > > > On Fri, Mar 26, 2021 at 7:33 PM McDaniel, Timothy > > > <[email protected]> wrote: > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Jerin Jacob <[email protected]> > > > > > Sent: Friday, March 26, 2021 6:01 AM > > > > > To: McDaniel, Timothy <[email protected]> > > > > > Cc: dpdk-dev <[email protected]>; Jerin Jacob <[email protected]>; Van > > > Haaren, > > > > > Harry <[email protected]>; Ray Kinsella <[email protected]>; > Neil > > > > > Horman <[email protected]>; Rao, Nikhil <[email protected]>; > > > > > Carrillo, Erik G <[email protected]>; Gujjar, Abhinandan S > > > > > <[email protected]>; Pavan Nikhilesh > > > > > <[email protected]>; Hemant Agrawal > > > <[email protected]>; > > > > > mattias.ronnblom <[email protected]>; Mccarthy, Peter > > > > > <[email protected]> > > > > > Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe > > > > > > > > > > On Thu, Mar 25, 2021 at 1:01 AM McDaniel, Timothy > > > > > <[email protected]> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Jerin Jacob <[email protected]> > > > > > > > Sent: Sunday, March 21, 2021 4:48 AM > > > > > > > To: McDaniel, Timothy <[email protected]> > > > > > > > Cc: dpdk-dev <[email protected]>; Jerin Jacob <[email protected]>; > Van > > > > > Haaren, > > > > > > > Harry <[email protected]>; Ray Kinsella > <[email protected]>; > > > Neil > > > > > > > Horman <[email protected]>; Rao, Nikhil > <[email protected]>; > > > > > > > Carrillo, Erik G <[email protected]>; Gujjar, Abhinandan S > > > > > > > <[email protected]>; Pavan Nikhilesh > > > > > > > <[email protected]>; Hemant Agrawal > > > > > <[email protected]>; > > > > > > > mattias.ronnblom <[email protected]>; Mccarthy, > Peter > > > > > > > <[email protected]> > > > > > > > Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 > > > > > > > probe > > > > > > > > > > > > > > On Wed, Mar 17, 2021 at 3:49 AM Timothy McDaniel > > > > > > > <[email protected]> wrote: > > > > > > > > > > > > > > > > This commit adds dlb v2.5 probe support, and updates > > > > > > > > parameter parsing. > > > > > > > > > > > > > > > > The dlb v2.5 device differs from dlb v2, in that the > > > > > > > > number of resources (ports, queues, ...) is different, > > > > > > > > so macros have been added to take the device version > > > > > > > > into account. > > > > > > > > > > > > > > > > This commit also cleans up a few issues in the original > > > > > > > > dlb2 source: > > > > > > > > - eliminate duplicate constant definitions > > > > > > > > - removed unused constant definitions > > > > > > > > > > > > > > > > Signed-off-by: Timothy McDaniel <[email protected]> > > > > > > > > --- > > > > > > > > > > > > > > > > > > > > > > > -#define EVDEV_DLB2_NAME_PMD dlb2_event > > > > > > > > +#define EVDEV_DLB2_NAME_PMD dlb_event > > > > > > > > > > > > > > Is this an intended change? why change the driver's name. > > > > > > > > > > > > Yes, This is an intentional change. We will be using the same > > > > > > driver > name > > > > > going forward, regardless of the hardware version. > > > > > > Internally, we know which version of the hardware is present. > > > > > > > > > > Since the driver name is still driver/event/dlb2. Keep it as same > > > > > prefix scheme with other drivers. > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > Tim > > > > > > > > > > > > > > Would it be acceptable to rename drivers/event/dlb2 to > > > > drivers/event/dlb? > > > > We may have additional dlb devices in the pipeline, such as v3, and we > would > > > really like > > > > to have them all use a common name. > > > > > > Makes sense to change to drivers/event/dlb. I think, we can make to > > > dlb when you > > > add v3 support. Now there is no need. > > > > > > > > > > > > > > Hi Jerin, > > > > I spoke to the team, and we would like to get this change in now. It happens > that we have > > several applications that use the eventdev API > rte_event_dev_get_dev_id(const char *name). > > Having a single name simplifies these applications, and also prevents > customers from having to > > update application source code every time a new dlb device is released. > > > Now that we removed drivers/event/dlb, Please rename > drivers/event/dlb2 as drivers/event/dlb. > and change EVDEV_DLB_NAME_PMD as dlb_event and submit the new patch > patches for v2.5. > > > > > > > Thanks, > > Tim > >
Thank you Jerin. I will make those changes and submit a new patch set containing this and the other requested changes. Best Regards, Tim
