Bruce, what do you think of the patch now? Do we need to add/change anything else, like documentation?
One thing to note is that we're changing the default behavior in this patch from machine=native to machine=generic (or more accurately, to cpu_instruction_set=generic). Do we want to do that? > -----Original Message----- > From: Juraj Linkeš <juraj.lin...@pantheon.tech> > Sent: Monday, March 29, 2021 2:51 PM > To: tho...@monjalon.net; david.march...@redhat.com; > bruce.richard...@intel.com; honnappa.nagaraha...@arm.com > Cc: dev@dpdk.org; Juraj Linkeš <juraj.lin...@pantheon.tech> > Subject: [PATCH v4] build: add platform meson option > > The current meson option 'machine' should only specify the ISA, which is not > sufficient for Arm, where setting ISA implies other setting as well. > Add a new meson option, 'platform', which differentiates the type of the build > (native/generic) and sets machine accordingly, unless the user chooses to > override it. > The 'machine' option also doesn't describe very well what it sets, so > introduce a > new option 'cpu_instruction_set', but keep 'machine' for backwards > compatibility. > These two new variables, taken together, achieve what 'machine' was setting > per architecture - setting the ISA in x86 build and setting native/default > 'build > type' in aarch64 build - is now properly being set for all architectures in a > uniform manner. > > Signed-off-by: Juraj Linkeš <juraj.lin...@pantheon.tech> > --- > config/arm/meson.build | 6 ++--- > config/meson.build | 47 +++++++++++++++++++++++++---------- > devtools/test-meson-builds.sh | 9 ++++--- > meson_options.txt | 8 ++++-- > 4 files changed, 48 insertions(+), 22 deletions(-) >
