Hi Ferruh, Indeed this patch is dependent on [1], it's also mentioned in the cover letter, I will rebase and post V4 addressing all the comments once [1] is accepted.
[1] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatches.dpdk.org%2Fproject%2Fdpdk%2Fpatch%2F1617180669-225007-1-git-send-email-jiaweiw%40nvidia.com%2F&data=04%7C01%7Csalems%40nvidia.com%7C477a7e09192e4c62c0e508d8f43d58f2%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637527891628225504%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=BB7zufQaPsAeu1l3jZ0xKOxtx86%2F0rUrUuSKQuVGn%2FE%3D&reserved=0 Thanks, -----Original Message----- From: Ferruh Yigit <ferruh.yi...@intel.com> Sent: Wednesday, March 31, 2021 3:06 PM To: Salem Sol <sal...@nvidia.com>; dev@dpdk.org Cc: Xiaoyun Li <xiaoyun...@intel.com>; NBU-Contact-Thomas Monjalon <tho...@monjalon.net> Subject: Re: [dpdk-dev] [PATCH v3 6/8] doc: update sample actions support in testpmd guide External email: Use caution opening links or attachments On 3/17/2021 9:26 AM, Salem Sol wrote: > Update documentation for sample action usage in testpmd utilizing > rte_flow_action_vxlan_encap and rte_flow_action_nvgre_encap and show > the command line example. > This patch has dependency to [1], right, can you please confirm it? [1]: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatches.dpdk.org%2Fproject%2Fdpdk%2Fpatch%2F1617180669-225007-1-git-send-email-jiaweiw%40nvidia.com%2F&data=04%7C01%7Csalems%40nvidia.com%7C477a7e09192e4c62c0e508d8f43d58f2%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637527891628225504%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=BB7zufQaPsAeu1l3jZ0xKOxtx86%2F0rUrUuSKQuVGn%2FE%3D&reserved=0 > Signed-off-by: Salem Sol <sal...@nvidia.com> > --- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 22 +++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 3a31cc6237..392e3a31cf 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -4901,6 +4901,28 @@ and also mirrored the packets with encapsulation > header and sent to port id 0. > testpmd> flow create 0 ingress transfer pattern eth / end actions > sample ratio 1 index 0 / port_id id 2 / end > > +E-Switch Mirroring rule, the matched ingress packets are sent to port > +id 2, and also mirrored the packets with VXLAN encapsulation header and sent > to port id 0. > + Similar comment on 'E-Switch', the mirroring is generic feature but 'E-Switch' is vendor specific, can you please update testpmd in a generic way? > +:: > + > + testpmd> set vxlan ip-version ipv4 vni 4 udp-src 4 udp-dst 4 ip-src > + testpmd> 127.0.0.1 > + ip-dst 128.0.0.1 eth-src 11:11:11:11:11:11 eth-dst > + 22:22:22:22:22:22 > + testpmd> set sample_actions 0 vxlan_encap / port_id id 0 / end flow > + testpmd> create 0 ingress transfer pattern eth / end actions > + sample ratio 1 index 0 / port_id id 2 / end > + > +E-Switch Mirroring rule, the matched ingress packets are sent to port > +id 2, and also mirrored the packets with NVGRE encapsulation header and sent > to port id 0. > + > +:: > + > + testpmd> set nvgre ip-version ipv4 tni 4 ip-src 127.0.0.1 ip-dst > + testpmd> 128.0.0.1 > + eth-src 11:11:11:11:11:11 eth-dst 22:22:22:22:22:22 > + testpmd> set sample_actions 0 nvgre_encap / port_id id 0 / end flow > + testpmd> create 0 ingress transfer pattern eth / end actions > + sample ratio 1 index 0 / port_id id 2 / end > + > BPF Functions > -------------- > >
