2015-05-29 15:26, Liang-Min Larry Wang: > adding a new library based upon ethdev APIs to provide API's that bear > the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops > (linux/netdevice.h). > > Signed-off-by: Liang-Min Larry Wang <liang-min.wang at intel.com> > --- > MAINTAINERS | 4 + > config/common_linuxapp | 5 + > lib/Makefile | 1 + > lib/librte_ethtool/Makefile | 56 +++++++ > lib/librte_ethtool/rte_ethtool.c | 155 +++++++++++++++++ > lib/librte_ethtool/rte_ethtool.h | 257 > +++++++++++++++++++++++++++++ > lib/librte_ethtool/rte_ethtool_version.map | 18 ++ > mk/rte.app.mk | 1 +
NACK for several reasons: - It's unclear what benefits this ethdev wrapper is bringing - There is no obvious interest (how is it supposed to be used?) - There is no update in the doc/ directory Other comments: - the patches are not versionned - the copyright starts in 2010 I'm curious to understand how renaming rte_eth_dev_set_mtu() to rte_ethtool_net_change_mtu() will help anyone.