From: Narcisa Vasile <navas...@microsoft.com>

Add function for thread creation, join, canceling.

Signed-off-by: Narcisa Vasile <navas...@microsoft.com>
---
 lib/librte_eal/common/rte_thread.c  | 110 ++++++++++++++++++++++++
 lib/librte_eal/include/rte_thread.h |  53 ++++++++++++
 lib/librte_eal/windows/rte_thread.c | 125 ++++++++++++++++++++++++++++
 3 files changed, 288 insertions(+)

diff --git a/lib/librte_eal/common/rte_thread.c 
b/lib/librte_eal/common/rte_thread.c
index 26c5b1f3c..29d38d193 100644
--- a/lib/librte_eal/common/rte_thread.c
+++ b/lib/librte_eal/common/rte_thread.c
@@ -120,6 +120,116 @@ rte_thread_attr_set_priority(rte_thread_attr_t 
*thread_attr,
        return 0;
 }
 
+int
+rte_thread_create(rte_thread_t *thread_id,
+                 const rte_thread_attr_t *thread_attr,
+                 void *(*thread_func)(void *), void *args)
+{
+       int ret = 0;
+       pthread_attr_t attr;
+       pthread_attr_t *attrp = NULL;
+       struct sched_param param = {
+               .sched_priority = 0,
+       };
+       int policy = SCHED_OTHER;
+
+       if (thread_attr != NULL) {
+               ret = pthread_attr_init(&attr);
+               if (ret != 0) {
+                       RTE_LOG(DEBUG, EAL, "pthread_attr_init failed\n");
+                       goto cleanup;
+               }
+
+               attrp = &attr;
+
+               /*
+                * Set the inherit scheduler parameter to explicit,
+                * otherwise the priority attribute is ignored.
+                */
+               ret = pthread_attr_setinheritsched(attrp,
+                                                  PTHREAD_EXPLICIT_SCHED);
+               if (ret != 0) {
+                       RTE_LOG(DEBUG, EAL, "pthread_attr_setinheritsched 
failed\n");
+                       goto cleanup;
+               }
+
+               /*
+                * In case a realtime scheduling policy is requested,
+                * the sched_priority parameter is set to the value stored in
+                * thread_attr. Otherwise, for the default scheduling policy
+                * (SCHED_OTHER) sched_priority needs to be initialized to 0.
+                */
+               if (thread_attr->priority == 
RTE_THREAD_PRIORITY_REALTIME_CRITICAL) {
+                       policy = SCHED_RR;
+                       param.sched_priority = thread_attr->priority;
+               }
+
+               ret = pthread_attr_setschedpolicy(attrp, policy);
+               if (ret != 0) {
+                       RTE_LOG(DEBUG, EAL, "pthread_attr_setschedpolicy 
failed\n");
+                       goto cleanup;
+               }
+
+               ret = pthread_attr_setschedparam(attrp, &param);
+               if (ret != 0) {
+                       RTE_LOG(DEBUG, EAL, "pthread_attr_setschedparam 
failed\n");
+                       goto cleanup;
+               }
+
+               ret = pthread_attr_setaffinity_np(attrp,
+                                                 sizeof(thread_attr->cpuset),
+                                                 &thread_attr->cpuset);
+               if (ret != 0) {
+                       RTE_LOG(DEBUG, EAL, "pthread_attr_setaffinity_np 
failed\n");
+                       goto cleanup;
+               }
+       }
+
+       ret = pthread_create(thread_id, attrp, thread_func, args);
+       if (ret != 0) {
+               RTE_LOG(DEBUG, EAL, "pthread_create failed\n");
+               goto cleanup;
+       }
+
+cleanup:
+       if (attrp != NULL)
+               pthread_attr_destroy(&attr);
+
+       return ret;
+}
+
+int
+rte_thread_join(rte_thread_t thread_id, int *value_ptr)
+{
+       int ret = 0;
+       void *res = NULL;
+       void **pres = NULL;
+
+       if (value_ptr != NULL)
+               pres = &res;
+
+       ret = pthread_join(thread_id, pres);
+       if (ret != 0) {
+               RTE_LOG(DEBUG, EAL, "pthread_join failed\n");
+               return ret;
+       }
+
+       if (pres != NULL)
+               *value_ptr = *(int *)(*pres);
+
+       return 0;
+}
+
+int rte_thread_cancel(rte_thread_t thread_id)
+{
+       /*
+        * TODO: Behavior is different between POSIX and Windows threads.
+        * POSIX threads wait for a cancellation point.
+        * Current Windows emulation kills thread at any point.
+        */
+       return pthread_cancel(thread_id);
+}
+
 int
 rte_thread_key_create(rte_thread_key *key, void (*destructor)(void *))
 {
diff --git a/lib/librte_eal/include/rte_thread.h 
b/lib/librte_eal/include/rte_thread.h
index f95efb319..fa643433a 100644
--- a/lib/librte_eal/include/rte_thread.h
+++ b/lib/librte_eal/include/rte_thread.h
@@ -200,6 +200,59 @@ __rte_experimental
 int rte_thread_attr_set_priority(rte_thread_attr_t *thread_attr,
                                 enum rte_thread_priority priority);
 
+/**
+ * Create a new thread that will invoke the 'thread_func' routine.
+ *
+ * @param thread_id
+ *    A pointer that will store the id of the newly created thread.
+ *
+ * @param thread_attr
+ *    Attributes that are used at the creation of the new thread.
+ *
+ * @param thread_func
+ *    The routine that the new thread will invoke when starting execution.
+ *
+ * @param args
+ *    Arguments to be passed to the 'thread_func' routine.
+ *
+ * @return
+ *   On success, return 0.
+ *   On failure, return a positive errno-style error number.
+ */
+__rte_experimental
+int rte_thread_create(rte_thread_t *thread_id,
+                     const rte_thread_attr_t *thread_attr,
+                     void *(*thread_func)(void *), void *args);
+
+/**
+ * Waits for the thread identified by 'thread_id' to terminate
+ *
+ * @param thread_id
+ *    The identifier of the thread.
+ *
+ * @param value_ptr
+ *    Stores the exit status of the thread.
+ *
+ * @return
+ *   On success, return 0.
+ *   On failure, return a positive errno-style error number.
+ */
+__rte_experimental
+int rte_thread_join(rte_thread_t thread_id, int *value_ptr);
+
+/**
+ * Terminates a thread.
+ *
+ * @param thread_id
+ *    The id of the thread to be cancelled.
+ *
+ * @return
+ *   On success, return 0.
+ *   On failure, return a positive errno-style error number.
+ */
+__rte_experimental
+int rte_thread_cancel(rte_thread_t thread_id);
+
 /**
  * Set core affinity of the current thread.
  * Support both EAL and non-EAL thread and update TLS.
diff --git a/lib/librte_eal/windows/rte_thread.c 
b/lib/librte_eal/windows/rte_thread.c
index f61103bbc..86bbd7bc2 100644
--- a/lib/librte_eal/windows/rte_thread.c
+++ b/lib/librte_eal/windows/rte_thread.c
@@ -329,6 +329,131 @@ rte_thread_attr_set_priority(rte_thread_attr_t 
*thread_attr,
        return 0;
 }
 
+int
+rte_thread_create(rte_thread_t *thread_id,
+                 const rte_thread_attr_t *thread_attr,
+                 void *(*thread_func)(void *), void *args)
+{
+       int ret = 0;
+       HANDLE thread_handle = NULL;
+       GROUP_AFFINITY thread_affinity;
+
+       thread_handle = CreateThread(NULL, 0,
+                               (LPTHREAD_START_ROUTINE)(ULONG_PTR)thread_func,
+                               args, 0, thread_id);
+       if (thread_handle == NULL) {
+               ret = rte_thread_translate_win32_error();
+               RTE_LOG_WIN32_ERR("CreateThread()");
+               goto cleanup;
+       }
+
+       if (thread_attr != NULL) {
+               if (CPU_COUNT(&thread_attr->cpuset) > 0) {
+                       ret = 
rte_convert_cpuset_to_affinity(&thread_attr->cpuset, &thread_affinity);
+                       if (ret != 0) {
+                               RTE_LOG(DEBUG, EAL, "Unable to convert cpuset 
to thread affinity\n");
+                               goto cleanup;
+                       }
+
+                       if (!SetThreadGroupAffinity(thread_handle, 
&thread_affinity, NULL)) {
+                               ret = rte_thread_translate_win32_error();
+                               RTE_LOG_WIN32_ERR("SetThreadGroupAffinity()");
+                               goto cleanup;
+                       }
+               }
+               ret = rte_thread_set_priority(*thread_id, 
thread_attr->priority);
+               if (ret != 0) {
+                       RTE_LOG(DEBUG, EAL, "Unable to set thread priority\n");
+                       goto cleanup;
+               }
+       }
+
+       return 0;
+
+cleanup:
+       if (thread_handle != NULL) {
+               CloseHandle(thread_handle);
+               thread_handle = NULL;
+       }
+       return ret;
+}
+
+int
+rte_thread_join(rte_thread_t thread_id, int *value_ptr)
+{
+       HANDLE thread_handle = NULL;
+       DWORD result = 0;
+       DWORD exit_code = 0;
+       BOOL err = 0;
+       int ret = 0;
+
+       thread_handle = OpenThread(SYNCHRONIZE | THREAD_QUERY_INFORMATION,
+                                  FALSE, thread_id);
+       if (thread_handle == NULL) {
+               ret = rte_thread_translate_win32_error();
+               RTE_LOG_WIN32_ERR("OpenThread()");
+               goto cleanup;
+       }
+
+       result = WaitForSingleObject(thread_handle, INFINITE);
+       if (result != WAIT_OBJECT_0) {
+               ret = rte_thread_translate_win32_error();
+               RTE_LOG_WIN32_ERR("WaitForSingleObject()");
+               goto cleanup;
+       }
+
+       if (value_ptr != NULL) {
+               err = GetExitCodeThread(thread_handle, &exit_code);
+               if (err == 0) {
+                       ret = rte_thread_translate_win32_error();
+                       RTE_LOG_WIN32_ERR("GetExitCodeThread()");
+                       goto cleanup;
+               }
+               *value_ptr = exit_code;
+       }
+
+cleanup:
+       if (thread_handle != NULL) {
+               CloseHandle(thread_handle);
+               thread_handle = NULL;
+       }
+
+       return ret;
+}
+
+int
+rte_thread_cancel(rte_thread_t thread_id)
+{
+       int ret = 0;
+       HANDLE thread_handle = NULL;
+
+       thread_handle = OpenThread(THREAD_TERMINATE, FALSE, thread_id);
+       if (thread_handle == NULL) {
+               ret = rte_thread_translate_win32_error();
+               RTE_LOG_WIN32_ERR("OpenThread()");
+               goto cleanup;
+       }
+
+       /*
+        * TODO: Behavior is different between POSIX and Windows threads.
+        * POSIX threads wait for a cancellation point.
+        * Current Windows emulation kills thread at any point.
+        */
+       ret = TerminateThread(thread_handle, 0);
+       if (ret != 0) {
+               ret = rte_thread_translate_win32_error();
+               RTE_LOG_WIN32_ERR("TerminateThread()");
+               goto cleanup;
+       }
+
+cleanup:
+       if (thread_handle != NULL) {
+               CloseHandle(thread_handle);
+               thread_handle = NULL;
+       }
+       return ret;
+}
+
 int
 rte_thread_key_create(rte_thread_key *key,
                __rte_unused void (*destructor)(void *))
-- 
2.30.0.vfs.0.2

Reply via email to