2021-03-26 09:22 (UTC+0100), Gabriel Ganne: > libpcap is already found and registered as a dependency by meson, and > the dependency is already correctly used in librte_port. This line is > just unnecessary. > > It also has the side effect of messing with the meson link line: dpdk > link will be declared twice: manually and then through pkg-config. If > you configure meson to prefer static linking over dynamic, this will > cause the build to fail on librte_port, since the pcap deps are not yet > seen by the linker. > > Signed-off-by: Gabriel Ganne <gabriel.ga...@6wind.com> > --- > config/meson.build | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/config/meson.build b/config/meson.build > index 66a2edcc47f5..95777cf33169 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -183,7 +183,6 @@ if not pcap_dep.found() > endif > if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep) > dpdk_conf.set('RTE_PORT_PCAP', 1) > - dpdk_extra_ldflags += '-lpcap' > endif > > # for clang 32-bit compiles we need libatomic for 64-bit atomic ops
This patch also simplifies future changes to discover libpcap on Windows. Acked-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com>