Hi Thomas,

I agree with the "ifcvf" name, as there might be more than one driver in a 
single driver dir.

Thanks,
Xiao

> -----Original Message-----
> From: Xu, Rosen <[email protected]>
> Sent: Tuesday, April 6, 2021 5:48 PM
> To: Thomas Monjalon <[email protected]>; Wang, Xiao W
> <[email protected]>
> Cc: [email protected]; Richardson, Bruce <[email protected]>;
> Hemant Agrawal <[email protected]>; Ajit Khaparde
> <[email protected]>; Griffin, John <[email protected]>;
> Trahe, Fiona <[email protected]>; Jain, Deepak K
> <[email protected]>; Raveendra Padasalagi
> <[email protected]>; Vikas Gupta
> <[email protected]>; John W. Linville <[email protected]>;
> Chas Williams <[email protected]>; Min Hu (Connor)
> <[email protected]>; Zhang, Tianfei <[email protected]>; Nipun
> Gupta <[email protected]>; [email protected]
> Subject: RE: [PATCH v2 3/3] drivers: align log names
> 
> HI Thomas,
> 
> I'm ok, if you replace pmd.afu.ipn3ke with pmd.net.ipn3ke. Thanks your
> reminder.
> 
> > -----Original Message-----
> > From: Thomas Monjalon <[email protected]>
> > Sent: Tuesday, April 06, 2021 17:31
> > To: Xu, Rosen <[email protected]>; Wang, Xiao W
> > <[email protected]>
> > Cc: [email protected]; Richardson, Bruce <[email protected]>;
> > Hemant Agrawal <[email protected]>; Ajit Khaparde
> > <[email protected]>; Griffin, John <[email protected]>;
> > Trahe, Fiona <[email protected]>; Jain, Deepak K
> > <[email protected]>; Raveendra Padasalagi
> > <[email protected]>; Vikas Gupta
> > <[email protected]>; John W. Linville <[email protected]>;
> > Chas Williams <[email protected]>; Min Hu (Connor)
> <[email protected]>;
> > Zhang, Tianfei <[email protected]>; Nipun Gupta
> > <[email protected]>; [email protected]
> > Subject: Re: [PATCH v2 3/3] drivers: align log names
> >
> > Hi Rosen,
> >
> > You already gave your ack in previous version, no need to re-ack.
> > Instead, please give your opinion and explanation as requested below.
> > We want to replace pmd.afu.ipn3ke with pmd.net.ipn3ke.
> > The use of AFU in the driver is not clear.
> >
> > Xiao, we need your opinion as well about ifcvf vs ifc name.
> >
> >
> > > > The log levels are configured by using the name of the logs.
> > > > Some drivers are aligned to follow a common log name standard:
> > > >         pmd.class.driver[.sub]
> > > > Some "common" drivers skip the "class" part:
> > > >         pmd.driver.sub
> > > >
> > > > Two drivers have exceptions to be clarified:
> > > >         pmd.vdpa.ifcvf instead of pmd.vdpa.ifc
> > > >         pmd.afu.ipn3ke instead of pmd.net.ipn3ke
> > > >
> > > > Signed-off-by: Thomas Monjalon <[email protected]>
> > > > Acked-by: Bruce Richardson <[email protected]>
> > > > Acked-by: Rosen Xu <[email protected]>
> > > > Acked-by: Xiao Wang <[email protected]>
> > > > Acked-by: Hemant Agrawal <[email protected]>
> > > > Acked-by: Ajit Khaparde <[email protected]>
> > [...]
> > > Acked-by: Rosen Xu <[email protected]>
> >
> >

Reply via email to