> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Thursday, April 8, 2021 1:58 PM > To: Van Haaren, Harry <[email protected]> > Cc: [email protected]; [email protected]; Ray Kinsella <[email protected]>; Neil Horman > <[email protected]>; Pavan Nikhilesh <[email protected]> > Subject: Re: [PATCH] service: clean references to removed symbol > > On Thu, Apr 8, 2021 at 2:54 PM Van Haaren, Harry > <[email protected]> wrote: > > > > > -----Original Message----- > > > From: David Marchand <[email protected]> > > > Sent: Wednesday, April 7, 2021 10:07 AM > > > To: [email protected] > > > Cc: [email protected]; Van Haaren, Harry <[email protected]>; Ray > > > Kinsella <[email protected]>; Neil Horman <[email protected]>; Pavan > > > Nikhilesh <[email protected]> > > > Subject: [PATCH] service: clean references to removed symbol > > > > > > rte_service_get_id() was removed in v17.11 but the API description > > > still referenced it and a version node was still present in EAL map. > > > > > > Fixes: 8edc9aaaf217 ("service: use id in get by name function") > > > Cc: [email protected] > > > > > > Signed-off-by: David Marchand <[email protected]> > > > > For rte_service.h doc changes I'm all fine. > > > > For ABI consistency, this removes a function from the DPDK_21 version map > > that > didn't exist in > > the shared object itself. I'm not sure if that's an ABI break or not... I > > see ABI > experts on CC, > > and will let them comment on that topic. > > The symbol is not in the API anymore. > Applications can't have a reference to this symbol without a definition.
Agreed, however I'm not familiar enough with linking/ABI stability to know if removing a symbol (even when not available in the API) could affect the resulting shared object's ABI. If somebody says there's no risk in ABI break, go ahead and merge. -Harry
