On Fri, Apr 9, 2021 at 5:33 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > > This seems to me like the test binary itself should be checking the > > > presence of hugepages, and reporting skips if necessary. It's not just > > > when > > > run through ninja that this functionality would be useful. > > > > Either way, there needs to be a rework - if we do it in the test binary, > > then the tests that require hugepages need to be worked so that they > > correctly detect lack of hugepage support before starting. If we keep > > that knowledge in the meson system, then we need to change the way we > > call the test binary script to support a more robust detection. > > > > I guess, I don't care too much which one is the one we choose. My $.02 > > opinion is that we already have most of the logic and whatnot done in > > the build system, so I'd prefer to do as small a change as possible > > (leaving that logic in the meson system). Then again, maybe it makes > > more sense to just rip the bandaid off and move it all into the test > > framework. > > > > WDYT? > > I think the test application should adapt to its environment. > If no hugepage, then mark the tests requiring hugepages as skipped. > For the other tests, we could use --in-memory.
There are tests that rely/test mp. They would have to be identified and skipped if we want to go with --in-memory. -- David Marchand
