> -----Original Message-----
> From: Tal Shnaiderman <[email protected]>
> Sent: Sunday, April 11, 2021 4:00 AM
> To: Xueming(Steven) Li <[email protected]>; NBU-Contact-Thomas Monjalon
> <[email protected]>; Gaetan Rivet
> <[email protected]>
> Cc: [email protected]; Xueming(Steven) Li <[email protected]>; Asaf Penso
> <[email protected]>; Wenzhuo Lu
> <[email protected]>; Beilei Xing <[email protected]>; Bernard
> Iremonger <[email protected]>; Gaetan Rivet
> <[email protected]>; Anatoly Burakov <[email protected]>; Dmitry Kozlyuk
> <[email protected]>; Narcisa Ana Maria
> Vasile <[email protected]>; Dmitry Malloy <[email protected]>;
> Pallavi Kadam <[email protected]>; Ray
> Kinsella <[email protected]>; Neil Horman <[email protected]>; Ferruh Yigit
> <[email protected]>; Andrew Rybchenko
> <[email protected]>
> Subject: RE: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage
>
> > Subject: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer
> > storage
> >
> > In current design, legacy parser rte_devargs_parse() saved scratch
> > buffer to devargs.args while new parser rte_devargs_layers_parse()
> > saved to devargs.data. Code using devargs had to know the difference
> > and cleaned up memory accordingly - error prone.
> >
> > This patch unifies scratch buffer to data field, introduces
> > rte_devargs_reset() function to wrap the memory clean up logic.
> >
> > Signed-off-by: Xueming Li <[email protected]>
> > Acked-by: Ray Kinsella <[email protected]>
> > Reviewed-by: Gaetan Rivet <[email protected]>
> > ---
> > app/test-pmd/config.c | 3 +-
> > app/test-pmd/testpmd.c | 5 +--
> > drivers/bus/vdev/vdev.c | 9 +++---
> > drivers/net/failsafe/failsafe_args.c | 3 +-
> > drivers/net/failsafe/failsafe_eal.c | 2 +-
> > examples/multi_process/hotplug_mp/commands.c | 6 ++--
> > lib/librte_eal/common/eal_common_dev.c | 9 +++---
> > lib/librte_eal/common/eal_common_devargs.c | 34 +++++++++++---------
> > lib/librte_eal/common/hotplug_mp.c | 6 ++--
> > lib/librte_eal/include/rte_devargs.h | 18 ++++++++---
> > lib/librte_eal/rte_eal_exports.def | 1 +
>
> rte_eal_exports.def was united with version.map and removed thus the
> modification above is unneeded.
Thanks, I'll rebase my code :)
>
> > lib/librte_eal/version.map | 1 +
> > lib/librte_ethdev/rte_ethdev.c | 8 ++---
> > 13 files changed, 59 insertions(+), 46 deletions(-)
