On 4/12/2021 2:06 PM, Thomas Monjalon wrote:
12/04/2021 14:59, Ferruh Yigit:
On 4/12/2021 12:25 PM, Raslan Darawsheh wrote:
Hi,
From: Tal Shnaiderman <tal...@nvidia.com>
Removed __ from the commit title to fix wrong headline format issue.
Several functions introduced in the addition of the Windows support to
mlx5 were missing the __rte_internal tag although being exported.
Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows")
Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on
Windows")
Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows")
Cc: sta...@dpdk.org
Signed-off-by: Tal Shnaiderman <tal...@nvidia.com>
Patch applied to next-net-mlx,
Can we merge this directly to main repo?
Since debug build is broken without it.
Which debug option?
It is broken since when?
"meson --buildtype=debug build && ninja -C build" is broken [1], I thought that
is why this patch is done at first place.
Some checks are done now only in the debug mode, since checks are reduced to
developer mode [2].
It become visible when .def file removed [3], since that is when symbols are
added to the .map file.
[1]
FAILED: drivers/rte_common_mlx5.sym_chk
.../meson --internal exe --capture drivers/rte_common_mlx5.sym_chk --
.../buildtools/check-symbols.sh .../drivers/common/mlx5/version.map
drivers/librte_common_mlx5.a
mlx5_os_umem_reg is not flagged as internal
but is listed in version map
Please add __rte_internal to the definition of mlx5_os_umem_reg
mlx5_os_umem_dereg is not flagged as internal
but is listed in version map
Please add __rte_internal to the definition of mlx5_os_umem_dereg
[2]
Commit 720dfda4551e ("build: limit symbol checks to developer mode")
[3]
Commit 56ea803e878e ("build: remove Windows export symbol list")
