> -----Original Message-----
> From: Shijith Thotton <sthot...@marvell.com>
> Sent: Monday, April 12, 2021 2:24 PM
> To: dev@dpdk.org
> Cc: Shijith Thotton <sthot...@marvell.com>; Gujjar, Abhinandan S
> <abhinandan.guj...@intel.com>; Jerin Jacob <jer...@marvell.com>; Akhil
> Goyal <gak...@marvell.com>; Anoob Joseph <ano...@marvell.com>
> Subject: [PATCH v2] eventdev: fix case to initiate crypto adapter service
>
> Initiate software crypto adapter service, only if hardware capabilities are
> not
> reported. In OP_FORWARD mode, software service is not required to
> enqueue events if OP_FORWARD capability is supported by the PMD.
>
> Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
>
> Signed-off-by: Shijith Thotton <sthot...@marvell.com>
> ---
> v2:
> - Reworded commit message.
>
> lib/librte_eventdev/rte_event_crypto_adapter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c
> b/lib/librte_eventdev/rte_event_crypto_adapter.c
> index d903cdd48..e1d38d383 100644
> --- a/lib/librte_eventdev/rte_event_crypto_adapter.c
> +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c
> @@ -861,6 +861,7 @@ rte_event_crypto_adapter_queue_pair_add(uint8_t
> id,
> * b. OP_NEW mode -> SW Dequeue
> */
> if ((cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW &&
> + !(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
The same check is below ORed with above condition.
This is confusing. Could you recheck & do the necessary changes?
> adapter->mode ==
> RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) ||
> (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) &&
> !(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> --
> 2.25.1
