13/04/2021 10:54, Jerin Jacob: > On Tue, Apr 13, 2021 at 12:46 PM David Marchand > <david.march...@redhat.com> wrote: > > > > On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <tho...@monjalon.net> > > wrote: > > > > > > 12/04/2021 15:20, Jerin Jacob Kollanukkaran: > > > > http://dpdk.org/git/next/dpdk-next-eventdev > > > > > > Pulled, thanks. > > > > > > Note few changes in titles like uppercases for acronyms, > > > or "add support" simplified as "support", > > > and release notes moved in the right place. > > > > The ABI check now reports an error on event/dlb. > > The reason is that the event/dlb driver has been removed, and so the > > check complains about a missing dump. > > This will have to be fixed quickly or reverted. > > > > > > This has been missed by multiple people, so trying to understand why. > > > I was running the following script[1] to detect ABI issues. > Since the "./devtools/test-meson-builds.sh" did not return non zero value or > the error print was "Error: cannot find librte_event_dlb.dump", It is > missed from my side. > > @David Marchand @Thomas Monjalon Could you share the snippet you are > using for detecting the ABI issue.
I do like you: simply run test-meson-builds.sh And yes I saw the error, and I don't know why I thought it was OK! We are humans :) > ------------------------ > # ABI check > DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash > ./devtools/test-meson-builds.sh 1> /tmp/build.log 2> /tmp/build.log > if [ $? -ne 0 ]; then > echo "ABI check failed" > exit > fi > > grep "Error: ABI issue reported" /tmp/build.log > if [ $? -eq 0 ]; then > echo "ABI issue" > exit > fi > > ------------------------------------------------------- > > > > The ABI check should have caught this when run by maintainers (/me > > looks at Thomas and Jerin). > > Sorry for that :-(