HI David, Thank you for the description and I will modify accordingly. -----Original Message----- From: David Marchand <david.march...@redhat.com> Sent: Wednesday, April 14, 2021 2:21 PM To: Haifei Luo <haif...@nvidia.com> Cc: Kinsella, Ray <m...@ashroe.eu>; dev@dpdk.org; Ori Kam <or...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com>; Raslan Darawsheh <rasl...@nvidia.com>; Xueming(Steven) Li <xuemi...@nvidia.com>; Matan Azrad <ma...@nvidia.com>; Shahaf Shuler <shah...@nvidia.com>; Neil Horman <nhor...@tuxdriver.com>; Yigit, Ferruh <ferruh.yi...@intel.com>; NBU-Contact-Thomas Monjalon <tho...@monjalon.net> Subject: Re: [PATCH v2 3/5] common/mlx5: add mlx5 APIs for single flow dump feature
External email: Use caution opening links or attachments On Wed, Apr 14, 2021 at 4:40 AM Haifei Luo <haif...@nvidia.com> wrote: > > HI David, > In current release, is the exports file necessary? I will keep the > modification if yes. Thank you. > > drivers/common/mlx5/rte_common_mlx5_exports.def It depends on the tree against which you send your patches. If this subtree (like next-net, or next-net-mlx) has been rebased on 56ea803e87 - build: remove Windows export symbol list (6 days ago) <David Marchand> Then no .def file is needed. Else, you should keep this .def update. In any case, this is easy to fix for maintainers who take the patch, since in your case, the .def update will trigger a conflict which can be just dropped. -- David Marchand
