On 4/19/2021 8:43 AM, Jack Min wrote:
On Tue, 21-04-13, 16:10, Jeff Guo wrote:
Add the new items to support the flow configuration for IP fragment
packets.

Signed-off-by: Ting Xu <ting...@intel.com>
Signed-off-by: Jeff Guo <jia....@intel.com>
---
  app/test-pmd/cmdline_flow.c | 21 ++++++++++++++++++++-
  1 file changed, 20 insertions(+), 1 deletion(-)

[...snip...]

+       [ITEM_IPV4_ID] = {
+               .name = "packet_id",
+               .help = "fragment packet id",
+               .next = NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED), item_param),
+               .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ipv4,
+                                            hdr.packet_id)),
+       },
        [ITEM_IPV4_FRAGMENT_OFFSET] = {
                .name = "fragment_offset",
                .help = "fragmentation flags and fragment offset",
@@ -2969,12 +2980,20 @@ static const struct token token_list[] = {
        },
        [ITEM_IPV6_FRAG_EXT_FRAG_DATA] = {
                .name = "frag_data",
-               .help = "Fragment flags and offset",
+               .help = "fragment flags and offset",
Will it be better to have a seperate fix patch for this ?


You refer the case update of the help string, 'F' -> 'f', right?
If so this is so small, and cosmetic, update, I think no need to have its own patch, and while this patch is touching related area, acceptable to fix it here.

Reply via email to