rte_prefetchX functions included volatile void *p as parameter, but the function does not modify it, so it should include the const keyword.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com> --- lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h | 6 +++--- lib/librte_eal/common/include/arch/x86/rte_prefetch.h | 12 ++++++------ lib/librte_eal/common/include/generic/rte_prefetch.h | 6 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h b/lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h index 9df0d13..fea3be1 100644 --- a/lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h @@ -39,17 +39,17 @@ extern "C" { #include "generic/rte_prefetch.h" -static inline void rte_prefetch0(volatile void *p) +static inline void rte_prefetch0(const volatile void *p) { asm volatile ("dcbt 0,%[p],1" : : [p] "r" (p)); } -static inline void rte_prefetch1(volatile void *p) +static inline void rte_prefetch1(const volatile void *p) { asm volatile ("dcbt 0,%[p],1" : : [p] "r" (p)); } -static inline void rte_prefetch2(volatile void *p) +static inline void rte_prefetch2(const volatile void *p) { asm volatile ("dcbt 0,%[p],1" : : [p] "r" (p)); } diff --git a/lib/librte_eal/common/include/arch/x86/rte_prefetch.h b/lib/librte_eal/common/include/arch/x86/rte_prefetch.h index ec2454d..688fa5e 100644 --- a/lib/librte_eal/common/include/arch/x86/rte_prefetch.h +++ b/lib/librte_eal/common/include/arch/x86/rte_prefetch.h @@ -40,19 +40,19 @@ extern "C" { #include "generic/rte_prefetch.h" -static inline void rte_prefetch0(volatile void *p) +static inline void rte_prefetch0(const volatile void *p) { - asm volatile ("prefetcht0 %[p]" : [p] "+m" (*(volatile char *)p)); + asm volatile ("prefetcht0 %[p]" : : [p] "m" (*(const volatile char *)p)); } -static inline void rte_prefetch1(volatile void *p) +static inline void rte_prefetch1(const volatile void *p) { - asm volatile ("prefetcht1 %[p]" : [p] "+m" (*(volatile char *)p)); + asm volatile ("prefetcht1 %[p]" : : [p] "m" (*(const volatile char *)p)); } -static inline void rte_prefetch2(volatile void *p) +static inline void rte_prefetch2(const volatile void *p) { - asm volatile ("prefetcht2 %[p]" : [p] "+m" (*(volatile char *)p)); + asm volatile ("prefetcht2 %[p]" : : [p] "m" (*(const volatile char *)p)); } #ifdef __cplusplus diff --git a/lib/librte_eal/common/include/generic/rte_prefetch.h b/lib/librte_eal/common/include/generic/rte_prefetch.h index 217f319..ee4a9ee 100644 --- a/lib/librte_eal/common/include/generic/rte_prefetch.h +++ b/lib/librte_eal/common/include/generic/rte_prefetch.h @@ -51,14 +51,14 @@ * @param p * Address to prefetch */ -static inline void rte_prefetch0(volatile void *p); +static inline void rte_prefetch0(const volatile void *p); /** * Prefetch a cache line into all cache levels except the 0th cache level. * @param p * Address to prefetch */ -static inline void rte_prefetch1(volatile void *p); +static inline void rte_prefetch1(const volatile void *p); /** * Prefetch a cache line into all cache levels except the 0th and 1th cache @@ -66,6 +66,6 @@ static inline void rte_prefetch1(volatile void *p); * @param p * Address to prefetch */ -static inline void rte_prefetch2(volatile void *p); +static inline void rte_prefetch2(const volatile void *p); #endif /* _RTE_PREFETCH_H_ */ -- 2.4.2