Hi Stephen Thanks your comments. We already change it in the following series and please take a look: https://patchwork.dpdk.org/project/dpdk/list/?series=16524 + /** + * Color the packet to reflect the meter color result. + * Set the meter color in the mbuf to the selected color. + * + * See struct rte_flow_action_meter_color. + */ + RTE_FLOW_ACTION_TYPE_METER_COLOR,
Regards, Li Zhang > -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Wednesday, April 21, 2021 1:56 AM > To: Li Zhang <l...@nvidia.com> > Cc: dek...@nvidia.com; Ori Kam <or...@nvidia.com>; Slava Ovsiienko > <viachesl...@nvidia.com>; Matan Azrad <ma...@nvidia.com>; Shahaf > Shuler <shah...@nvidia.com>; lir...@marvell.com; > jasvinder.si...@intel.com; NBU-Contact-Thomas Monjalon > <tho...@monjalon.net>; Ferruh Yigit <ferruh.yi...@intel.com>; Andrew > Rybchenko <andrew.rybche...@oktetlabs.ru>; Cristian Dumitrescu > <cristian.dumitre...@intel.com>; dev@dpdk.org; Raslan Darawsheh > <rasl...@nvidia.com>; Roni Bar Yanai <ron...@nvidia.com> > Subject: Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter > policy API > > External email: Use caution opening links or attachments > > > On Thu, 18 Mar 2021 10:58:14 +0200 > Li Zhang <l...@nvidia.com> wrote: > > > + > > + /** > > + * Color the packet to reflect the meter color result. > > + * > > + * See struct rte_flow_action_color. > > + */ > > + RTE_FLOW_ACTION_TYPE_COlOR, > > Why the odd use of lower case here? Shouldn't it be > RTE_FLOW_ACTION_TYPE_COLOR
