29/04/2021 08:16, Gregory Etelson: > Add integrity item definition to the rte_flow_desc_item array. > The new entry allows to build RTE flow item from a data > stored in rte_flow_item_integrity type. > > Add bitmasks to the integrity item value. > The masks allow to query multiple integrity filters in a single > compare operation. > > Fixes: b10a421a1f3b ("ethdev: add packet integrity check flow rules") > > Signed-off-by: Gregory Etelson <getel...@nvidia.com> > Acked-by: Viacheslav Ovsiienko <viachesl...@nvidia.com> > --- > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > +#define RTE_FLOW_ITEM_INTEGRITY_PKT_OK RTE_BIT64(0) > +#define RTE_FLOW_ITEM_INTEGRITY_L2_OK RTE_BIT64(1) > +#define RTE_FLOW_ITEM_INTEGRITY_L3_OK RTE_BIT64(2) > +#define RTE_FLOW_ITEM_INTEGRITY_L4_OK RTE_BIT64(3) > +#define RTE_FLOW_ITEM_INTEGRITY_L2_CRC_OK RTE_BIT64(4) > +#define RTE_FLOW_ITEM_INTEGRITY_IPV4_CSUM_OK RTE_BIT64(5) > +#define RTE_FLOW_ITEM_INTEGRITY_L4_CSUM_OK RTE_BIT64(6) > +#define RTE_FLOW_ITEM_INTEGRITY_L3_LEN_OK RTE_BIT64(7)
I still have the same comment as in v1: we are missing an API comment to reference the bits RTE_FLOW_ITEM_INTEGRITY_* where it should be used.