On 4/29/2021 11:52 AM, Jiawen Wu wrote: > On Friday, April 9, 2021 10:47 PM, Ferruh Yigit wrote: >> On 4/6/2021 10:30 AM, Jiawen Wu wrote: >>> This patch set provides a skeleton of ngbe PMD, which adapted to >>> Wangxun WX1860 series NICs. >>> >>> v4: >>> - Fix compile error. >>> >>> v3: >>> - Use rte_ether functions to define marcos. >>> >>> v2: >>> - Correct some clerical errors. >>> - Use ethdev debug flags instead of driver own. >>> >>> Jiawen Wu (6): >>> net/ngbe: add build and doc infrastructure >>> net/ngbe: add device IDs >>> net/ngbe: support probe and remove >>> net/ngbe: add device init and uninit >>> net/ngbe: add log type and error type >>> net/ngbe: define registers >>> >> >> Hi Jiawen, >> >> I put some comments on some patches, but as far as I can see the device is >> not >> functional yet after this set, I assume rest of the support will be submitted >> later. >> But I think the device should have at least bare minimum functionality when >> it >> is upstreamed, like proper device initialization and primitive Rx/Tx, also >> it would >> be good to have basic control functions. >> More control and datapath functionality can be added gradually later. >> >> What do you think extending this set to have base minimum functionality? >> >> Thanks, >> ferruh > > Hi Ferruh, > > Unfortunately, this driver may not be merged in 21.05, to follow the roadmap. > There is not enough time for me to improve the patches, because I was busy > with other works in these weeks. > > I'll try my best to submit the driver in this release cycle, and hope it will > be merged nicely in next release. >
That is OK, thanks for heads up.