On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> As the documentation of rte_kvargs_parse() states, the valid_keys
> argument must be NULL terminated. Lack of this feature may cause
> segmentation fault if the passed devarg will be different then the
> supported value.
>
> Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers")
> Cc: [email protected]
>
> Signed-off-by: Michal Krawczyk <[email protected]>
> Reviewed-by: Igor Chauskin <[email protected]>
> Reviewed-by: Shay Agroskin <[email protected]>
> ---
> drivers/net/ena/ena_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index cb8ad5c3d0..6092288239 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -2876,6 +2876,7 @@ static int ena_parse_devargs(struct ena_adapter
> *adapter,
> {
> static const char * const allowed_args[] = {
> ENA_DEVARG_LARGE_LLQ_HDR,
> + NULL,
> };
> struct rte_kvargs *kvlist;
> int rc;
>
Acked-by: Ferruh Yigit <[email protected]>make sen
