> -----Original Message-----
> From: Akhil Goyal <gak...@marvell.com>
> Sent: Sunday, May 9, 2021 12:21 PM
> To: Matan Azrad <ma...@nvidia.com>; dev@dpdk.org
> Cc: Suanming Mou <suanmi...@nvidia.com>; NBU-Contact-Thomas
> Monjalon <tho...@monjalon.net>; Shiri Kuzin <shi...@nvidia.com>
> Subject: RE: [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations
>
> External email: Use caution opening links or attachments
>
>
> > > > +static void
> > > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev,
> > > > + struct rte_cryptodev_sym_session *sess) {
> > > > + struct mlx5_crypto_priv *priv = dev->data->dev_private;
> > > > + struct mlx5_crypto_session *sess_private_data =
> > > > + get_sym_session_private_data(sess,
> > > > +dev->driver_id);
> > > > +
> > > > + if (unlikely(sess_private_data == NULL)) {
> > > > + DRV_LOG(ERR, "Failed to get session %p private data.",
> > > > + sess_private_data);
> > > > + return;
> > > > + }
> > > > + mlx5_crypto_dek_destroy(priv, sess_private_data->dek);
> > > > + DRV_LOG(DEBUG, "Session %p was cleared.", sess_private_data); }
> > >
> > > Memory leakage, mempool is not freed.
> >
> > Yes, good catch, this part was missed.
> >
> > > IMO, this driver is not properly tested with the unit test app.
> >
> > The only app we tested until now is l2fwd_crypto and it works fine!
> > We can add it to doc.
> >
> > > Please add a note in the documentation that it is tested with autotest.
> >
> >
> > The next app we want to test with, is test-crypto-perf.
> >
> I would recommend to run the test app first.
> It will catch most of your basic bugs like the one above.
It is too late for this, will add the test adjustment later.
