> -----Original Message-----
> From: Rong, Leyi <[email protected]>
> Sent: Tuesday, May 11, 2021 5:20 PM
> To: Zhang, AlvinX <[email protected]>; Xing, Beilei
> <[email protected]>; Zhang, Qi Z <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: RE: [PATCH v3] net/i40e: fix offload flag checking in simple Tx
> datapath
>
>
> > -----Original Message-----
> > From: Zhang, AlvinX <[email protected]>
> > Sent: Tuesday, May 11, 2021 4:46 PM
> > To: Xing, Beilei <[email protected]>; Rong, Leyi
> > <[email protected]>
> > Cc: [email protected]; Zhang, AlvinX <[email protected]>;
> > [email protected]
> > Subject: [PATCH v3] net/i40e: fix offload flag checking in simple Tx
> > datapath
> >
> > Tx offload flags 'PKT_TX_IPV6, PKT_TX_IPV4, PKT_TX_OUTER_IPV6,
> > PKT_TX_OUTER_IPV4' are supported in simple datapath.
> >
> > This patch removes these offload flags from packet checking in simple
> > Tx datapath and defines 2 macro I40E_TX_OFFLOAD_SIMPLE_SUP_MASK
> and
> > I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK.
> >
> > Fixes: 146ffa81d05e ("net/i40e: add Tx preparation for simple Tx
> > datapath")
> > Cc: [email protected]
> >
> > Signed-off-by: Alvin Zhang <[email protected]>
> > ---
> >
> > v3: Update codes according to comments
> > ---
> > drivers/net/i40e/i40e_rxtx.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_rxtx.c
> > b/drivers/net/i40e/i40e_rxtx.c index 02cf5e7..337916b 100644
> > --- a/drivers/net/i40e/i40e_rxtx.c
> > +++ b/drivers/net/i40e/i40e_rxtx.c
> > @@ -72,6 +72,15 @@
> > #define I40E_TX_OFFLOAD_NOTSUP_MASK \
> > (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK)
> >
> > +#define I40E_TX_OFFLOAD_SIMPLE_SUP_MASK ( \
> > + PKT_TX_IPV4 | \
> > + PKT_TX_IPV6 | \
> > + PKT_TX_OUTER_IPV4 | \
> > + PKT_TX_OUTER_IPV6)
> > +
> > +#define I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK \
> > + (PKT_TX_OFFLOAD_MASK ^
> > I40E_TX_OFFLOAD_SIMPLE_SUP_MASK)
> > +
> > int
> > i40e_get_monitor_addr(void *rx_queue, struct rte_power_monitor_cond
> > *pmc) { @@ -1501,7 +1510,7 @@
> > return i;
> > }
> >
> > - if (ol_flags & PKT_TX_OFFLOAD_MASK) {
> > + if (ol_flags & I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK) {
> > rte_errno = ENOTSUP;
> > return i;
> > }
> > --
> > 1.8.3.1
>
> Acked-by: Leyi Rong <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi
