Hi Adam,

> -----Original Message-----
> From: dev <[email protected]> On Behalf Of Zhang, Roy Fan
> Sent: Monday, May 10, 2021 12:42 PM
> To: Dybkowski, AdamX <[email protected]>; [email protected];
> Kusztal, ArkadiuszX <[email protected]>; [email protected]
> Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix NULL authentication request
> 
> > -----Original Message-----
> > From: Dybkowski, AdamX <[email protected]>
> > Sent: Monday, May 10, 2021 11:20 AM
> > To: [email protected]; Zhang, Roy Fan <[email protected]>; Kusztal,
> > ArkadiuszX <[email protected]>; [email protected]
> > Cc: Dybkowski, AdamX <[email protected]>
> > Subject: [PATCH] crypto/qat: fix NULL authentication request
> >
> > This patch fixes the NULL auth generation case where the request
> > shouldn't contain the authentication result address. Allows to run
> > ipsec_autotest with a QAT device.
> >
> > Fixes: 65beb9abca6d ("crypto/qat: fix null auth when using VFIO")
> >
> > Signed-off-by: Adam Dybkowski <[email protected]>
> > ---
> >  drivers/crypto/qat/qat_sym.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/crypto/qat/qat_sym.c
> > b/drivers/crypto/qat/qat_sym.c index a1f5676c04..9415ec7d32 100644
> > --- a/drivers/crypto/qat/qat_sym.c
> > +++ b/drivers/crypto/qat/qat_sym.c
> > @@ -399,8 +399,10 @@ qat_sym_build_request(void *in_op, uint8_t
> > *out_msg,
> >             }
> >             min_ofs = auth_ofs;
> >
> > -           auth_param->auth_res_addr =
> > -                   op->sym->auth.digest.phys_addr;
> > +           if (ctx->qat_hash_alg != ICP_QAT_HW_AUTH_ALGO_NULL
> ||
> > +                           ctx->auth_op ==
> > ICP_QAT_HW_AUTH_VERIFY)
> > +                   auth_param->auth_res_addr =
> > +                                   op->sym->auth.digest.phys_addr;
> >
> >     }
> >
> > --
> > 2.25.1
> 
> Acked-by: Fan Zhang <[email protected]>

This patch should be backported, the following line should be added after the 
Fixes line:
Cc: [email protected]

Regards,

Bernard.

Reply via email to