> -----Original Message----- > From: Yigit, Ferruh <ferruh.yi...@intel.com> > Sent: Tuesday, May 11, 2021 2:21 PM > To: Dumitrescu, Cristian <cristian.dumitre...@intel.com>; Haifei Luo > <haif...@nvidia.com>; ma...@nvidia.com; or...@nvidia.com; > viachesl...@nvidia.com; Li, Xiaoyun <xiaoyun...@intel.com> > Cc: dev@dpdk.org; tho...@monjalon.net; rasl...@nvidia.com; Singh, > Jasvinder <jasvinder.si...@intel.com> > Subject: Re: [PATCH v2] app/testpmd: add CLI for action meter color > > On 5/11/2021 1:34 PM, Dumitrescu, Cristian wrote: > > > > > >> -----Original Message----- > >> From: Yigit, Ferruh <ferruh.yi...@intel.com> > >> Sent: Tuesday, May 11, 2021 12:35 PM > >> To: Haifei Luo <haif...@nvidia.com>; ma...@nvidia.com; > or...@nvidia.com; > >> viachesl...@nvidia.com; Li, Xiaoyun <xiaoyun...@intel.com> > >> Cc: dev@dpdk.org; tho...@monjalon.net; rasl...@nvidia.com; Singh, > >> Jasvinder <jasvinder.si...@intel.com>; Dumitrescu, Cristian > >> <cristian.dumitre...@intel.com> > >> Subject: Re: [PATCH v2] app/testpmd: add CLI for action meter color > >> > >> On 5/11/2021 10:28 AM, Haifei Luo wrote: > >>> Currently action RTE_FLOW_ACTION_TYPE_METER_COLOR is defined. > >>> Add the CLI for this action in meter policy: color type (types) > >>> There are three types: green, yellow and red. > >>> > >>> Example for the new policy meter CLIs: > >>> add port meter policy 0 1 g_actions color type green / end y_actions > >>> color type yellow / end r_actions color type red / end > >>> > >>> In the above command, the action type is > >> RTE_FLOW_ACTION_TYPE_METER_COLOR, > >>> the meter policy action list: green -> green, yellow -> yellow, red -> > >>> red. > >>> > >>> V2: rebase the latest code. > >>> > >>> Signed-off-by: Haifei Luo <haif...@nvidia.com> > >>> Acked-by: Ori Kam <or...@nvidia.com> > >> > >> > >> cc'ed Jasvinder & Cristian for review. > >> > >> This patch is not a fix but adding support for testing new meter action > type, > >> so > >> I assume it can be postponed to next release if missing review from > >> maintainers. > > > > Hi Ferruh, > > > > This patch looks good to me, but I think it should be reviewed and acked by > Xiaoyun, the testpmd maintainer, who is already in the To: list? > > > > If so I will proceed with your explicit ack: > Cristian Dumitrescu <cristian.dumitre...@intel.com> > > Xiaoyun is main maintainer but for some submodules we rely on the relevant > maintainer, like flow API related part to Ori or for meter/tm part to you > etc..
Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com>
