> -----Original Message----- > From: Feifei Wang <[email protected]> > Sent: Thursday, 20 May, 2021 10:44 > To: Griffin, John <[email protected]>; Trahe, Fiona > <[email protected]>; Jain, Deepak K <[email protected]>; > Herbert Guan <[email protected]>; Jerin Jacob > <[email protected]> > Cc: [email protected]; Yigit, Ferruh <[email protected]>; Dybkowski, > AdamX <[email protected]>; [email protected]; Feifei Wang > <[email protected]>; [email protected]; Ruifeng Wang > <[email protected]> > Subject: [PATCH v4] crypto/qat: fix uninitilized gcc compiler warning > > In Arm platform, when "RTE_ARCH_ARM64_MEMCPY" is set as true, gcc > will report variable uninitilized warning: > > ../drivers/crypto/qat/qat_sym_session.c: In function > ‘partial_hash_compute’: > ../lib/eal/include/generic/rte_byteorder.h:241:24: warning: > ‘<U35a0>’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > 241 | #define rte_bswap32(x) __builtin_bswap32(x) > ... > > This is because "digest" will be initialized by "rte_memcpy" function rather > than "memcpy" if "RTE_ARCH_ARM64_MEMCPY" is set as true. > Furthermore, 'rte_memcpy' will initialize 'digest' with two steps by invoking > rte_mov_x functions. For example: > > partial_hash_sha1 -> rte_memcpy -> rte_memcpy_ge16_lt_128 -> step 1: > rte_mov16(dst,src ) step 2: rte_mov16(dst - 16 + n, src - 16 + n) > > However, gcc compiler cannot identify this multi-step initialization, then it > will report warning. > > To fix this, use "memset" to initialize "digest". > > Fixes: cd7fc8a84b48 ("eal/arm64: optimize memcpy") > Cc: [email protected] > > Signed-off-by: Feifei Wang <[email protected]> > Reviewed-by: Ruifeng Wang <[email protected]> > ---
Acked-by: Adam Dybkowski <[email protected]>
