On Mon, May 24, 2021 at 11:31 AM Thierry Herbelot <[email protected]> wrote: > > Use stats only after it was checked not to be NULL. > > Fixes: af1ae8b6a32c9 ("graph: implement stats") > Cc: [email protected] > Cc: Jerin Jacob <[email protected]> > Cc: Kiran Kumar K <[email protected]> > > Signed-off-by: Thierry Herbelot <[email protected]> > -- > V2: reword patch title > --- > lib/graph/graph_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c > index 125e08d73290..a52994f0f61e 100644 > --- a/lib/graph/graph_stats.c > +++ b/lib/graph/graph_stats.c > @@ -119,8 +119,8 @@ stats_mem_init(struct cluster *cluster, > cluster_node_size = RTE_ALIGN(cluster_node_size, RTE_CACHE_LINE_SIZE); > > stats = realloc(NULL, sz); > - memset(stats, 0, sz); > if (stats) { > + memset(stats, 0, sz); > stats->fn = fn; > stats->cluster_node_size = cluster_node_size; > stats->max_nodes = 0;
Please update your patches status in patchwork when submitting new revisions. Besides, the same fix had been posted by Min Hu: http://patchwork.dpdk.org/project/dpdk/patch/[email protected]/ -- David Marchand
