Hi Akhil, Please see inline.
Thanks, Anoob > -----Original Message----- > From: Akhil Goyal <[email protected]> > Sent: Thursday, June 17, 2021 1:41 AM > To: Anoob Joseph <[email protected]>; Thomas Monjalon > <[email protected]> > Cc: Tejasree Kondoj <[email protected]>; Jerin Jacob Kollanukkaran > <[email protected]>; Ankur Dwivedi <[email protected]>; > [email protected]; Anoob Joseph <[email protected]>; Archana Muniganti > <[email protected]>; Srujana Challa <[email protected]> > Subject: RE: [PATCH 3/4] crypto/cnxk: add security session ops > > > diff --git a/drivers/crypto/cnxk/meson.build > > b/drivers/crypto/cnxk/meson.build index ab45483..eea08fa 100644 > > --- a/drivers/crypto/cnxk/meson.build > > +++ b/drivers/crypto/cnxk/meson.build > > @@ -13,6 +13,7 @@ sources = files( > > 'cn9k_cryptodev_ops.c', > > 'cn10k_cryptodev.c', > > 'cn10k_cryptodev_ops.c', > > + 'cn10k_ipsec.c', > > 'cnxk_cpt_ops_helper.c', > > 'cnxk_cryptodev.c', > > 'cnxk_cryptodev_capabilities.c', @@ -20,4 +21,4 @@ sources = > > files( > > 'cnxk_cryptodev_sec.c', > > ) > > > > -deps += ['bus_pci', 'common_cnxk', 'security'] > > +deps += ['bus_pci', 'common_cnxk', 'security', 'rte_net'] > > -- > This should be 'net' and not 'rte_net'. > Do we really need this dependency? [Anoob] It was required since we had a dependency on rte_esp.h. But, as you said, we don't need to make it as dependency on 'net'. Something like, includes += include_directories('../../../lib/net') Is good enough. Will have this changed so.
