On Fri, Jun 18, 2021 at 4:09 PM Nithin Dabilpuram <[email protected]> wrote: > > This patchset adds support for Marvell CN106XX SoC based on 'common/cnxk' > driver. In future, CN9K a.k.a octeontx2 will also be supported by same > driver when code is ready and 'net/octeontx2' will be deprecated.
Looks good to me in general, a couple of final comments 1) Build issue with RHEL 7 (gcc 4.8) http://mails.dpdk.org/archives/test-report/2021-June/199620.html 2) Shorten git subject messages( for explicit "add" etc) Example: From: net/cnxk: add DMAC filter support to: net/cnxk: support DMAC filter 3) Add Cc: [email protected] for following patch common/cnxk: fix batch alloc completion poll logic 4) Fix following camel case CHECK:CAMELCASE: Avoid CamelCase: <roc_model_is_cn96_Ax> #92: FILE: drivers/net/cnxk/cnxk_ethdev.c:122: + if (roc_model_is_cn96_Ax() && 5) Replace INTERNAL in drivers/net/cnxk/version.map 6) Add [rte_flow items] and [rte_flow actions] in doc/guides/nics/features/cnxk_vec.ini and doc/guides/nics/features/cnxk_vf.ini
