Re: [dpdk-dev] [RFC PATCH v3 1/3] sched: add PIE based congestion management

[Liguzinski, WojciechX]

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org> 
> Sent: Monday, June 21, 2021 8:18 PM
> To: Liguzinski, WojciechX <wojciechx.liguzin...@intel.com>
> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.si...@intel.com>; Dumitrescu, 
> Cristian <cristian.dumitre...@intel.com>; Dharmappa, Savinay 
> <savinay.dharma...@intel.com>; Ajmera, Megha <megha.ajm...@intel.com>
> Subject: Re: [dpdk-dev] [RFC PATCH v3 1/3] sched: add PIE based congestion 
> management
>
> On Mon, 21 Jun 2021 08:35:04 +0100
> "Liguzinski, WojciechX" <wojciechx.liguzin...@intel.com> wrote:
>
> > +/**
> > + * @brief Initialises run-time data
> > + *
> > + * @param pie [in,out] data pointer to PIE runtime data
> > + *
> > + * @return Operation status
> > + * @retval 0 success
> > + * @retval !0 error
> > + */
> > +int
> > +rte_pie_rt_data_init(struct rte_pie *pie);
>
> All the new code needs to be marked experimental.
> Why return an error on the init() function, then you are going to make 
> application check the result and lead to lots more code.
>
> Other places in DPDK use void for init functions.

Thanks for comments.
I'll apply necessary updates to V4 of RFC patches.

BR,
Wojciech