On Tue, Jun 01, 2021 at 09:56:52AM +0800, Feifei Wang wrote: > From: Phil Yang <phil.y...@arm.com> > > Because dpdk guide does not limit the relative path for ABI > compatibility check, users maybe set 'DPDK_ABI_REF_DIR' as a relative > path: > > ~/dpdk/devtools$ DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=build-gcc-shared > ./test-meson-builds.sh > > And if the DESTDIR is not an absolute path, ninja complains: > + install_target build-gcc-shared/v19.11/build > build-gcc-shared/v19.11/build-gcc-shared > + rm -rf build-gcc-shared/v19.11/build-gcc-shared > + echo 'DESTDIR=build-gcc-shared/v19.11/build-gcc-shared ninja -C > build-gcc-shared/v19.11/build install' > + DESTDIR=build-gcc-shared/v19.11/build-gcc-shared > + ninja -C build-gcc-shared/v19.11/build install > ... > ValueError: dst_dir must be absolute, got > build-gcc-shared/v19.11/build-gcc-shared/usr/local/share/dpdk/ > examples/bbdev_app > ... > Error: install directory 'build-gcc-shared/v19.11/build-gcc-shared' does not > exist. > > To fix this, add relative path support using 'readlink -f'. > > Signed-off-by: Phil Yang <phil.y...@arm.com> > Signed-off-by: Feifei Wang <feifei.wa...@arm.com> > Reviewed-by: Juraj Linkeš <juraj.lin...@pantheon.tech> > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> > --- > devtools/test-meson-builds.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index daf817ac3e..43b906598d 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -168,7 +168,8 @@ build () # <directory> <target cc | cross file> <ABI > check> [meson options] > config $srcdir $builds_dir/$targetdir $cross --werror $* > compile $builds_dir/$targetdir > if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then > - abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION > + abirefdir=$(readlink -f \ > + ${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION) > if [ ! -d $abirefdir/$targetdir ]; then > # clone current sources > if [ ! -d $abirefdir/src ]; then
This looks a simple enough change. Acked-by: Bruce Richardson <bruce.richard...@intel.com>