On 6/25/2021 2:26 PM, Igor Ryzhov wrote: > Hi Ferruh, all, > > Let's please discuss another approach to setting KNI link status before > making this API stable: > http://patches.dpdk.org/project/dpdk/patch/20190925093623.18419-1-iryz...@nfware.com/ > > I explained the problem with the current implementation there. > More than that, using ioctl approach makes it possible to set also speed > and duplex and use them to implement get_link_ksettings callback. > I can send patches for both features. >
Hi Igor, agree to discuss your patch before promoting the API, I will comment on the outstanding patch. > Igor > > On Thu, Jun 24, 2021 at 4:54 PM Kinsella, Ray <m...@ashroe.eu> wrote: > >> Sounds more than reasonable, +1 from me. >> >> Ray K >> >> On 24/06/2021 14:24, Ferruh Yigit wrote: >>> On 6/24/2021 11:42 AM, Kinsella, Ray wrote: >>>> Hi Ferruh, >>>> >>>> The following kni experimental symbols are present in both v21.05 and >> v19.11 release. These symbols should be considered for promotion to stable >> as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= >> 2yrs at this point. >>>> >>>> * rte_kni_update_link >>>> >>>> Ray K >>>> >>> >>> Hi Ray, >>> >>> Thanks for follow up. >>> >>> I just checked the API and planning a small behavior update to it. >>> If the update is accepted, I suggest keeping the API experimental for >> 21.08 too, >>> but can mature it on v21.11. >>> >>> Thanks, >>> ferruh >>> >>
