On Tue, Jun 16, 2015 at 11:07:28AM +0200, Thomas Monjalon wrote: > 2015-06-03 16:07, Thomas Monjalon: > > 2015-05-08 10:58, Vladimir Medvedkin: > > > Software implementation of the Toeplitz hash function used by RSS. > > > Can be used either for packet distribution on single queue NIC > > > or for simulating of RSS computation on specific NIC (for example > > > after GRE header decapsulating). > > > > > > v3 changes > > > - Rework API to be more generic > > > - Add sctp_tag into tuple > > > > > > v2 changes > > > - Add ipv6 support > > > - Various style fixes > > > > > > Signed-off-by: Vladimir Medvedkin <medvedkinv at gmail.com> > > > --- > > > lib/librte_hash/Makefile | 1 + > > > lib/librte_hash/rte_thash.h | 207 > > > ++++++++++++++++++++++++++++++++++++++++++++ > > > > Without any comment, it seems this v3 is approved. > > Maybe that this patch would be even better by implementing some unit tests. > > I wonder if the hash chapter of the prog guide could list the different > > algorithms and why/when use them? > > Bruce, any opinion? > Don't you think that unit tests are required?
Sorry, I missed this patch set. I'll take a look at it today. /Bruce
