On Fri, Jun 18, 2021 at 12:51 PM Pavan Nikhilesh Bhagavatula <pbhagavat...@marvell.com> wrote: > > > > >-----Original Message----- > >From: Ruifeng Wang <ruifeng.w...@arm.com> > >Sent: Thursday, June 10, 2021 12:55 PM > >To: Pavan Nikhilesh Bhagavatula <pbhagavat...@marvell.com>; Shijith > >Thotton <sthot...@marvell.com> > >Cc: dev@dpdk.org; n...@arm.com; Ruifeng Wang > ><ruifeng.w...@arm.com> > >Subject: [EXT] [PATCH] event/cnxk: fix clang warning on Arm > > > >External Email > > > >---------------------------------------------------------------------- > >Build with Clang-10 has warning: > >drivers/event/cnxk/cnxk_tim_worker.h:372:23: warning: value size > >does not match register size specified by the constraint and modifier [- > >Wasm-operand-widths] > > : [rem] "=&r"(rem) > > ^ > >drivers/event/cnxk/cnxk_tim_worker.h:365:17: note: use constraint > >modifier "w" > > " ldxr %[rem], [%[crem]] \n" > > ^~~~~~ > > %w[rem] > > > >Changed variable type to match register size, which placates clang. > > > >Fixes: 300b796262a1 ("event/cnxk: add timer arm routine") > >Cc: pbhagavat...@marvell.com > > > >Signed-off-by: Ruifeng Wang <ruifeng.w...@arm.com> > > LGTM, thanks. > > Acked-by: Pavan Nikhilesh <pbhagavat...@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks > > >--- > > drivers/event/cnxk/cnxk_tim_worker.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/event/cnxk/cnxk_tim_worker.h > >b/drivers/event/cnxk/cnxk_tim_worker.h > >index 7caeb1a8fb..78e36ffafe 100644 > >--- a/drivers/event/cnxk/cnxk_tim_worker.h > >+++ b/drivers/event/cnxk/cnxk_tim_worker.h > >@@ -320,7 +320,7 @@ cnxk_tim_add_entry_mp(struct cnxk_tim_ring > >*const tim_ring, > > struct cnxk_tim_ent *chunk; > > struct cnxk_tim_bkt *bkt; > > uint64_t lock_sema; > >- int16_t rem; > >+ int64_t rem; > > > > __retry: > > cnxk_tim_get_target_bucket(tim_ring, rel_bkt, &bkt, > >&mirr_bkt); > >-- > >2.25.1 >