On Thu, Jul 01, 2021 at 09:34:04AM +0100, Luca Boccassi wrote:
> On Wed, 2021-06-30 at 19:22 +0300, Dmitry Kozlyuk wrote:
> > The `doc` target used `echo` as its command.
> > On Windows, `echo` is always a shell built-in, there is no binary.
> > Starting from meson 0.58, `run_target()` always searches for command
> > executable and no longer accepts `echo` as such on Windows.
> > Replace plain `echo` with a Python one-liner.
> >
> > Fixes: d02a2dab2dfb ("doc: support building HTML guides with meson")
> > Cc: Bruce Richardson <[email protected]>
> > Cc: Luca Boccassi <[email protected]>
> > Cc: [email protected]
> >
> > Reported-by: Rob Scheepens <[email protected]>
> > Signed-off-by: Dmitry Kozlyuk <[email protected]>
> > ---
>
> Acked-by: Luca Boccassi <[email protected]>
One small suggestion might be to move the "echo" command definition to
buildtools folder in case it's wanted for use anywhere in the build at some
point in the future. However, this patch is fine without that change too.
Acked-by: Bruce Richardson <[email protected]>
