> -----Original Message----- > From: dev <[email protected]> On Behalf Of David Marchand > Sent: Tuesday, June 29, 2021 16:07 > To: [email protected] > Cc: Igor Russkikh <[email protected]>; Aaron Conole <[email protected]>; > Michael Santana > <[email protected]>; Richardson, Bruce <[email protected]>; > Rasesh Mody > <[email protected]>; Shahed Shaikh <[email protected]>; Yang, Qiming > <[email protected]>; Zhang, > Qi Z <[email protected]>; Heinrich Kuhn <[email protected]>; > Devendra Singh Rawat > <[email protected]>; Ray Kinsella <[email protected]>; Neil Horman > <[email protected]>; Dmitry > Kozlyuk <[email protected]>; Narcisa Ana Maria Vasile > <[email protected]>; Dmitry > Malloy <[email protected]>; Kadam, Pallavi <[email protected]> > Subject: [dpdk-dev] [PATCH v3 2/2] eal: handle compressed firmwares > > Introduce an internal firmware loading helper to remove code duplication > in our drivers and handle xz compressed firmwares by calling libarchive. > > This helper tries to look for .xz suffixes so that drivers are not aware > the firmwares have been compressed. > > libarchive is set as an optional dependency: without libarchive, a > runtime warning is emitted so that users know there is a compressed > firmware. > > Windows implementation is left as an empty stub. > > Signed-off-by: David Marchand <[email protected]> > Reviewed-by: Igor Russkikh <[email protected]> > --- > Changes since v2: > - added a comment on libarchive link dependency, > > Changes since v1: > - used pkg-config for libarchive detection, > - updated doxygen annotations, > - added internal helpers in eal_firmware.c to enhance readability, > - dropped whitespace damage in version.map, > > --- > .github/workflows/build.yml | 1 + > .travis.yml | 1 + > config/meson.build | 10 +++ > drivers/net/bnx2x/bnx2x.c | 35 +++----- > drivers/net/ice/ice_ethdev.c | 60 +++----------
For ice PMD: Tested-by: Haiyue Wang <[email protected]> > drivers/net/nfp/nfp_net.c | 57 +++---------- > drivers/net/qede/qede_main.c | 45 ++++------ > lib/eal/include/rte_firmware.h | 32 +++++++ > lib/eal/unix/eal_firmware.c | 149 +++++++++++++++++++++++++++++++++ > lib/eal/unix/meson.build | 1 + > lib/eal/version.map | 1 + > lib/eal/windows/eal.c | 9 ++ > 12 files changed, 259 insertions(+), 142 deletions(-) > create mode 100644 lib/eal/include/rte_firmware.h > create mode 100644 lib/eal/unix/eal_firmware.c > > -- > 2.23.0
