Hi, > -----Original Message----- > From: Pai G, Sunil <sunil.pa...@intel.com> > Sent: Thursday, July 8, 2021 3:15 PM > To: Jiang, Cheng1 <cheng1.ji...@intel.com>; maxime.coque...@redhat.com; > Xia, Chenbo <chenbo....@intel.com> > Cc: dev@dpdk.org; Hu, Jiayu <jiayu...@intel.com>; Yang, YvonneX > <yvonnex.y...@intel.com> > Subject: RE: [dpdk-dev] [PATCH v2 1/3] vhost: add unsafe API to drain pkts in > async vhost > > Hi Cheng, > > Repsonse inline. > > <snipped> > > > As for this one, I'm not sure why we need have the loop in the application. > > The function of this API is that caller need to drain all the inflight > > pkts, it should be called only once to get the job done. > > Don't you think? > > Perhaps yes, but my thought was to provide application the flexibility to > change the DMA device per call to check_completed_copies callback if it did > require it.
Got your point. So you think this API should be defined as the unsafe version of poll completed API, right? Thanks, Cheng > > > > > Thanks. > > Cheng > > > > > > > > > + > > > > + return n_pkts; > > > > +} > > > > + > > > > > > <snipped> > > > > > >
