Hi Akhil, > -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Tuesday, July 20, 2021 4:14 PM > To: Shiri Kuzin <shi...@nvidia.com>; NBU-Contact-Thomas Monjalon > <tho...@monjalon.net>; Matan Azrad <ma...@nvidia.com>; Suanming Mou > <suanmi...@nvidia.com> > Cc: david.march...@redhat.com; dev@dpdk.org > Subject: RE: [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD > > > > > > > > v2: > > > > - Add data-path part. > > > > > > > > v3: > > > > - Rebase. > > > > > > > > v4: > > > > - Rebase + Address the following Akhil comments: > > > > - Set HW feature flag in the capability patch. > > > > - Fix mp object release in session clear. > > > > - Some spelling and word missing in doc. > > > > - Squash data-unit adjustment to the session operations commit. > > > > - Wording: device argument -> devarg. > > > > > > > > v5: > > > > - Add mlx5 crypto tests into test library. > > > > - Update documentation according to Akhil comments. > > > > - Fix memory region management. > > > > - Fix multi segment case in data-path code. > > > > - Split documentation to the correct commits according to Akhil > > comments. > > > > - Rebase to new version. > > > > - Change license to Nvidia license. > > > > > > > > v6: > > > > - Rebase to new version. > > > > - Address David's comment and update log accordingly. > > > > - Update testing app commits as suggested by Akhil. > > > > > > > > v7: > > > > - Rebase to new version. > > > > - Add scatter gather and OOP test cases. > > > > > > > > v8: > > > > - Add a test case that was removed by error. > > > > > > > > > > > > > > > > Shiri Kuzin (11): > > > > drivers: introduce mlx5 crypto PMD > > > > crypto/mlx5: add DEK object management > > > > > > This is really bad, I was planning to apply this series today, It > > > had small issues, so was planning to fix them while applying. > > > But when I applied the 2/16, it does not compile. > > > Please fix this, we are into v8 and compilation is broken. > > > > > > I am adding few more comments, please fix them too in your next > > > version As soon as possible. I was planning to close RC2 during > > > weekend, but it > > looks > > > It will fall over next week. > > > > > Please review this patchset thoroughly within Nvidia before sending > > next version. > > Take reference to other crypto PMDs for patch splitting and sequencing. > > Are we expecting next version today? > This is the only major patchset left for RC2. > Any update?
Sorry for the late reply, Shiri is not available these days, so I'm trying to follow up the status and update the new version later today. Regarding the compilation failure, it's due to the crypto patch series depends on some mlx5 common code. The mlx5 common code has some changes and I assume Shiri rebased the version with the dpdk-next-mlx and meanwhile the dpdk-next-crypto branch still did not get the latest mlx5 common code. I just checked the dpdk-next-crypto branch, seems the mlx5 part is still not updated yet. So will you also sync up the crypto branch today? If no, then the failure will come again. I'm not so familiar with the branch update procedure, but we will need the branch to be updated to the version below: http://git.dpdk.org/next/dpdk-next-net-mlx/commit/?id=7e1cf892711b9ba237563b6c876382caaec434f7 Thanks, SuanmingMou
