On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay <[email protected]> wrote: > > > -----Original Message----- > > From: Jerin Jacob <[email protected]> > > Sent: Wednesday, July 28, 2021 3:01 PM > > To: Jayatheerthan, Jay <[email protected]> > > Cc: Naga Harish K, S V <[email protected]>; [email protected] > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
> > > > > > > > > > > > > Signed-off-by: Naga Harish K, S V <[email protected]> > > > > > > @Naga Harish K, S V Can we remove "," from the Signoff name. > > > > Some suggestions for consideration in preferred order. Let me know > > your preferred Signoff name, I will change it accordingly. > > > > Naga Harish <[email protected]> > > > > or > > > > Naga Harish K <[email protected]> > > > > or > > > > Naga Harish K S V <[email protected]> > > This option is good. (Harish is out and hence I am responding) 1) Option 'Signed-off-by: Naga Harish K S V <[email protected]> is warned by checkpatch [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1 ### eventdev: fix event port setup in Tx adapter WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "Naga Harish K, S V" <[email protected]>' != 'Signed-off-by: Naga Harish K S V <[email protected]>' 2) Option 'Signed-off-by: Naga Harish K, S V <[email protected]>' is warning by check-git-log.sh [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1 Wrong tag: Signed-off-by: Naga Harish K, S V <[email protected]> @thomas @David Marchand Could you suggest what Sign-off to take? > > > > > > > --- > > > > lib/eventdev/rte_event_eth_tx_adapter.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c > > > > b/lib/eventdev/rte_event_eth_tx_adapter.c > > > > index db260bfb68..18c0359db7 100644 > > > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c > > > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c > > > > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, > > > > uint8_t dev_id, > > > > return ret; > > > > } > > > > > > > > - pc->event_port_cfg = 0; > > > > ret = rte_event_port_setup(dev_id, port_id, pc); > > > > if (ret) { > > > > RTE_EDEV_LOG_ERR("failed to setup event port %u\n", > > > > -- > > > > 2.25.1
