On Thu, Aug 19, 2021 at 4:15 PM Dmitry Kozlyuk <[email protected]> wrote: > > Windows EAL depends on some system libraries. They were linked using > add_project_link_arguments('-l<LIB>'), which prevented meson from adding > them to Libs.private of pkg-config file. As a result, applications using > pkg-config to find DPDK hit link errors, for example: > > librte_eal.a(eal_windows_eal_debug.c.obj) : error LNK2019: unresolved > external symbol __imp_SymInitialize referenced in function > rte_dump_stack > > Reference required libraries in EAL using ext_deps meson variable. > bus/pci and net/pcap depend on lib/eal and will pull them automatically. > Drop advapi32 dependency, as MinGW locates VirtualAlloc2() dynamically. > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > Fixes: c91717eb75c8 ("eal/windows: support exit and panic") > Cc: [email protected] > Cc: [email protected] > > Reported-by: William Tu <[email protected]> > Signed-off-by: Dmitry Kozlyuk <[email protected]> > ---
Thanks for the fix. I've tested on my Windows environment and it works ok. the libdpdk.pc shows the required libraries. Acked-by: William Tu <[email protected]>
